Skip to content

Kbdev 1500 storybook - #123

Merged
areisle merged 8 commits into
developfrom
KBDEV-1500-storybook
Apr 14, 2026
Merged

Kbdev 1500 storybook#123
areisle merged 8 commits into
developfrom
KBDEV-1500-storybook

Conversation

@areisle

@areisle areisle commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

adds storybook as well as stories for many components. did not add stories for any views in this PR as the PR was already quite large but will add some for those in future as well. for this I focused on the components involved in the forms since those will be the focus of the next tickets

kttkjl
kttkjl previously approved these changes Apr 11, 2026
Base automatically changed from KBDEV-1499-react-upgrade to develop April 13, 2026 17:45
@areisle
areisle dismissed kttkjl’s stale review April 13, 2026 17:45

The base branch was changed.

@areisle
areisle force-pushed the KBDEV-1500-storybook branch from 7179c24 to 9362036 Compare April 13, 2026 17:48
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.66%. Comparing base (cd8ba21) to head (ef05cef).

Files with missing lines Patch % Lines
src/views/MainView/index.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #123      +/-   ##
===========================================
+ Coverage    48.39%   53.66%   +5.26%     
===========================================
  Files          119      120       +1     
  Lines         4467     4547      +80     
  Branches      1545     1547       +2     
===========================================
+ Hits          2162     2440     +278     
+ Misses        1948     1784     -164     
+ Partials       357      323      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kttkjl
kttkjl self-requested a review April 14, 2026 23:04
@areisle
areisle merged commit 2ef25aa into develop Apr 14, 2026
3 checks passed
@areisle
areisle deleted the KBDEV-1500-storybook branch April 14, 2026 23:21
@github-actions

Copy link
Copy Markdown

Unit Test Results

    1 files  ±    0    41 suites  +9   1m 28s ⏱️ +44s
289 tests +156  287 ✔️ +157  2 💤  - 1  0 ❌ ±0 
289 runs  +155  287 ✔️ +156  2 💤  - 1  0 ❌ ±0 

Results for commit 2ef25aa. ± Comparison against base commit cd8ba21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants